fixed resolution of some language variables in permissions #4676
Conversation
There was a problem hiding this comment.
Thanks @schmitz-ilias for fixing this.
Please have a look at the comments, there are only two minor issues.
| @@ -325,7 +325,7 @@ protected function readRoleProperties(ilObjRole $role) | |||
|
|
|||
| $rbacreview = $DIC['rbacreview']; | |||
|
|
|||
| $data['title'] = $role->getTitle(); | |||
| $data['title'] = $role->_getTranslation($role->getTitle()); | |||
There was a problem hiding this comment.
Please change this to a static call, since the method is static: ilObjRole::_getTranslation(...)
| @@ -46,6 +46,15 @@ public function __construct($a_id = 0, $a_call_by_reference = false) | |||
| } | |||
|
|
|||
|
|
|||
| /** | |||
| * return translated title for autogenerated templates | |||
| * @return string | |||
There was a problem hiding this comment.
Please remove the phpdoc-comment (\return string), since it does not provide additional information.
fixed resolution of some language variables in permissions
fixed resolution of some language variables in permissions
|
This PR causes a change in the display of the title in the "Edit Properties" dialog of the role. |
|
Hi @iljalukin, I talked to @smeyer-ilias about the issue you brought up. We propose to not revert to the previous behavior, but instead to add the role title in the form il_crs_admin_12345 in brackets to the end of the title in the header of the role GUI. |
Fixed the resolution of language variables in the permissions, see https://mantis.ilias.de/view.php?id=32909. This includes the name of custom roles from plugins, the name of all roles in the log, and the name of custom operations from plugins in the permissions table.